Skip to content

Include user in login result - #163

Merged
bajtos merged 2 commits into
masterfrom
feature/include-user-in-login-result
Jan 30, 2014
Merged

bajtos merged 2 commits into
masterfrom
feature/include-user-in-login-result

Conversation

@bajtos

@bajtos bajtos commented Jan 30, 2014

Copy link
Copy Markdown
Member

The first commit is unrelated, it improves the ngdoc documentation generated by loopback-angular.

The second commit implements the necessary changes.

Close #161. See also #162.

/to: @ritch please review
/cc: @raymondfeng
/cc: @seanbrookes This change should simplify your iCars controllers, as you don't have to send two requests on login (User.login, User.get).

@slnode

slnode commented Jan 30, 2014

Copy link
Copy Markdown

Test FAILed. To trigger a build add comment - ".test\W+please"
Refer to this link for build results: http://ci.strongloop.com/job/loopback/859/

@bajtos

bajtos commented Jan 30, 2014

Copy link
Copy Markdown
Member Author

Note: there is one test failing, the failure was introduced by loopbackio/loopback-datasource-juggler@cf200a2.

@raymondfeng Could you please investigate and fix the problem?

@raymondfeng

Copy link
Copy Markdown
Member

The regression should be fixed by #164

Miroslav Bajtoš added 2 commits January 30, 2014 18:09
Add an explicit note that clients are not supposed to send the
`access_token` parameter, since it is extracted from request
headers.
Allow LB clients to get details of the currently logged-in user
as part of the login response.

Improve method's `description` to mention this new option.
@bajtos

bajtos commented Jan 30, 2014

Copy link
Copy Markdown
Member Author

Thank you @raymondfeng for fixing the regression quickly. I have rebased my commits on top of current master.

@slnode

slnode commented Jan 30, 2014

Copy link
Copy Markdown

Test PASSed. To trigger a build add comment - ".test\W+please"
Refer to this link for build results: http://ci.strongloop.com/job/loopback/862/

@ritch

ritch commented Jan 30, 2014

Copy link
Copy Markdown
Member

LGTM

bajtos added a commit that referenced this pull request Jan 30, 2014
@bajtos
bajtos merged commit c36e205 into master Jan 30, 2014
@bajtos
bajtos deleted the feature/include-user-in-login-result branch January 30, 2014 18:33
wdoug added a commit to codefordenver/encorelink that referenced this pull request Nov 2, 2016
See strongloop/loopback#163
for context on how this works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The quest for a better User.login

4 participants